Improved property tests with null examples that reveals bugs#3
Open
luisggpina wants to merge 1 commit intodragan-ivanovic:masterfrom
Open
Improved property tests with null examples that reveals bugs#3luisggpina wants to merge 1 commit intodragan-ivanovic:masterfrom
luisggpina wants to merge 1 commit intodragan-ivanovic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
In an effort to improve the coverage of the property tests, I improved the existing property tests to test
nullhandling and found some bugs:testInsertionadds a bunch of keys mapping tonullthat cause aNullPointerExceptionwhen balancing the tree:testDeletionattempts to delete keys from an empty map, which also causesNullPointerExceptionas the delete operation sometimes returns an empty map and other times returnsnull:More info on how to replicate these issues: