Skip to content

Conversation

@gaius-qi
Copy link
Member

Description

This pull request updates the project to version 1.1.14 and ensures all internal dependencies are using the new version. Additionally, it updates a method call in the gRPC upload server handler to use a more specific function for replication downloads.

Version and dependency updates:

  • Bumped the workspace and all internal dependency versions from 1.1.13 to 1.1.14 in Cargo.toml to keep the project and its components in sync. [1] [2]

Code improvement:

  • Updated the gRPC upload server handler in dragonfly-client/src/grpc/dfdaemon_upload.rs to use the download_for_replication method instead of the generic download, likely clarifying intent and improving code maintainability.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.4.0 milestone Dec 26, 2025
@gaius-qi gaius-qi self-assigned this Dec 26, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Dec 26, 2025
…plica

Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.84%. Comparing base (7f71dee) to head (7c9d248).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/resource/persistent_task.rs 0.00% 25 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
- Coverage   42.89%   42.84%   -0.06%     
==========================================
  Files          75       75              
  Lines       21159    21184      +25     
==========================================
  Hits         9077     9077              
- Misses      12082    12107      +25     
Files with missing lines Coverage Δ
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
dragonfly-client/src/resource/persistent_task.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi enabled auto-merge (squash) December 26, 2025 10:41
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 7c55571 into main Dec 26, 2025
7 checks passed
@gaius-qi gaius-qi deleted the feature/replica branch December 26, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants