-
Notifications
You must be signed in to change notification settings - Fork 0
Add --disable-spec-validation flag to process specs with validation or reference issues #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: dreamquality <130073078+dreamquality@users.noreply.github.com>
…idation/ref issues Co-authored-by: dreamquality <130073078+dreamquality@users.noreply.github.com>
|
@copilot add more tests and verify cli tool works fine |
…6 new tests) Co-authored-by: dreamquality <130073078+dreamquality@users.noreply.github.com>
Added 16 comprehensive tests (total now 183 tests, all passing). Tests cover: Unit tests (13): broken refs, JSON specs, circular refs, missing fields, edge cases Verified CLI works correctly with:
Commit: [Short hash will be shown after push] |
…r reference issues Co-authored-by: dreamquality <130073078+dreamquality@users.noreply.github.com>
|
@copilot update readme.md and prepare release.yml file |
Co-authored-by: dreamquality <130073078+dreamquality@users.noreply.github.com>
Updated documentation and release workflow. Changes include: README.md:
release.yml:
Ready for release workflow execution. Commit: 08d4f33 |
Co-authored-by: dreamquality <130073078+dreamquality@users.noreply.github.com>
Removed several features from the release notes and summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new --disable-spec-validation flag to handle OpenAPI/Swagger specifications with validation or reference issues. This allows the tool to process and calculate coverage for specs that might have broken references or validation errors.
- Add
--disable-spec-validationCLI flag to bypass spec validation - Update
loadAndParseSpecfunction to support disabling validation - Add comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/disable-spec-validation.test.js | New comprehensive unit tests for the disable validation feature |
| test/disable-spec-validation-cli.test.js | New CLI integration tests for the --disable-spec-validation flag |
| readme.md | Documentation updates including new CLI option and usage examples |
| lib/swagger.js | Core implementation to support disabling validation in loadAndParseSpec |
| cli.js | CLI option definition and flag passing to the core library |
| auto-detect-newman.html | Timestamp update in test fixture |
| .github/workflows/release.yml | Release notes updates for the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Implementation Complete ✅
Summary
Updated documentation and release workflow to include the new
--disable-spec-validationflag.Changes Made
1. README.md Updates
--disable-spec-validationto CLI options section2. Release.yml Updates
Documentation Structure
README.md additions:
Release.yml additions:
Testing
Ready for Release
Documentation is now complete and ready for the next release with comprehensive information about the
--disable-spec-validationfeature.Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.