added window_zoomed_flag to show_directory_in_window_status_current#1
Conversation
|
Yes please merge this into the plugin. I am also looking for it. |
|
I tried your branch and it doesn't work anymore I think, when zooming a pane it doesn't show anything special on my side... |
|
@Knackii it's been a while since i touched this so the specific syntax slips my mind. Without any additional context it's hard to envision the nature of the bug. possible checks
You can try editing the (original) interested disclaimerAll of this with the caveat of correctly sourcing the configuration via |
|
Oops, I think it's because I tried on your repo without specifying the branch your feature is on 😅 I assumed it was on your main but I didn't see you did a PR from one of your other branches... It's still not working because I have another issue but it's not related to that I think.. |
|
Sorry for the delay on reviewing this. My GH notifications are finally fixed. I like this feature a lot and will aim to merge it in. Ideally if we can configure it somehow that way anyone using it who doesn't want to isn't affected. |
Felt like it happened very often that i missed the context of having a pane zoomed in.
=> Added a unicode char (respecting active window colour palette) and showing IFF
window_zoomed_flagis1Might be better to add a whole new
show_directory_and_zoom_in_window_status_currentto have a clean selection but could be an overcomplication.
Choice of unicode char was optimal on my screen/fontsize, should be easy enough to switch it for unicode supporting terminals.
Very unsure as if this PR process is ok by me and follows common etiquette, this would be my first PR ever. Apologies if I'm out of order.