MINOR: Fix macOS build failures by making brew uninstall commands non-fatal #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jarbuild workflow was failing on macOS because it tried to uninstall Homebrew formulas that don't exist or aren't installed: - aws-sdk-cpp (may not be installed) - re2 (may not be installed) - protobuf (may not be installed) These uninstall commands were failing with exit code 1, causing the entire build to fail. By adding '|| :' to these commands, we make them non-fatal so the build can continue even if the formulas aren't installed. The grpc and grpc@1.54 uninstall commands already had '|| :' and were working correctly.
timhurskidremio
changed the title
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jarbuild workflow was failing on macOS because it tried to uninstall Homebrew formulas that don't exist or aren't installed:
These uninstall commands were failing with exit code 1, causing the entire build to fail. By adding '|| :' to these commands, we make them non-fatal so the build can continue even if the formulas aren't installed.
The grpc and grpc@1.54 uninstall commands already had '|| :' and were working correctly.