Fix catalog search result calculation#3
Open
elvetemedve wants to merge 1 commit intodrewdhunter-pers:masterfrom
elvetemedve:hotfix/catalogsearch-results-count
Open
Fix catalog search result calculation#3elvetemedve wants to merge 1 commit intodrewdhunter-pers:masterfrom elvetemedve:hotfix/catalogsearch-results-count
elvetemedve wants to merge 1 commit intodrewdhunter-pers:masterfrom
elvetemedve:hotfix/catalogsearch-results-count
Conversation
The way how the module calculates the number of results is incorrect. When a layered navigation filter is active and the result is zero, then the module still thinks it has non-zero results, because only the search keyword is taken into account. This commit builds the navigation layer model properly by applying all active filters and finally counts the number of items in the result collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way how the module calculates the number of results is incorrect. When a layered navigation filter is active and the result is zero, then the module still thinks it has non-zero results, because only the search keyword is taken into account. This commit builds the navigation layer model properly by applying all active filters and finally counts the number of items in the result collection.