lburg - fix strchr when buffer doesn't have an eol.#23
Open
ksherlock wants to merge 1 commit intodrh:masterfrom
Open
lburg - fix strchr when buffer doesn't have an eol.#23ksherlock wants to merge 1 commit intodrh:masterfrom
ksherlock wants to merge 1 commit intodrh:masterfrom
Conversation
if strchr(bp, '\n') didn't find anything the first time, it won't find anything the second time, either. Change to '\0' to find the end-of-line. It's still a syntax error (the grammar requires a '\n') but it won't cause an alloc error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if
strchr(bp, '\n')didn't find anything the first time, it won't find anything the second time, either.Change to
'\0'to find the end-of-line. It's still a syntax error (the grammar requires a'\n') but it won't cause an alloc error.This is only an issue if there's no end-of-line while lexing a rule's cost code (so not a problem with any of lcc's files).