Open
Conversation
…_order When modifying an order, if the existing order is a TriggerLimit that has already been triggered, it will now be automatically converted to a Limit order. This ensures that once a trigger limit order is triggered, it behaves as a regular limit order with the limit price instead of maintaining trigger-related fields. However, if the user is explicitly trying to modify the trigger price (modify_order_params.trigger_price is Some), the conversion is skipped to handle race conditions where the user updates the trigger price while the order gets triggered.
0xbigz
force-pushed
the
modify-order-trigger-limit-to-limit
branch
from
374324a to
65a9aad
Compare
…_order When modifying an order, if the existing order is a TriggerLimit that has already been triggered, it will now be automatically converted to a Limit order. This ensures that once a trigger limit order is triggered, it behaves as a regular limit order with the limit price instead of maintaining trigger-related fields. However, if the user is explicitly trying to modify the trigger price (modify_order_params.trigger_price is Some), the conversion is skipped to handle race conditions where the user updates the trigger price while the order gets triggered.
0xbigz
force-pushed
the
modify-order-trigger-limit-to-limit
branch
from
65a9aad to
995059d
Compare
crispheaney
reviewed
Feb 4, 2026
| modify_order_params | ||
| .trigger_price | ||
| .or(Some(existing_order.trigger_price)), | ||
| modify_order_params |
Member
There was a problem hiding this comment.
if it's already been triggered you have to reset the trigger condition as the previous code did?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: convert triggered TriggerLimit orders to Limit orders in modify_order
When modifying an order, if the existing order is a TriggerLimit that has already been triggered, it will now be automatically converted to a Limit order. This ensures that once a trigger limit order is triggered, it behaves as a regular limit order with the limit price instead of maintaining trigger-related fields.
However, if the user is explicitly trying to modify the trigger price (modify_order_params.trigger_price is Some), the conversion is skipped to handle race conditions where the user updates the trigger price while the order gets triggered.