Nick/add scale orders ix by lowkeynicc · Pull Request #2093 · drift-labs/protocol-v2

lowkeynicc · 2026-01-28T17:41:40Z

No description provided.

LukasDeco · 2026-01-29T00:03:22Z

programs/drift/src/state/scale_order_params/tests.rs

+}
+
+#[test]
+fn test_ascending_size_distribution() {


Tests looking great! With ascending and descending, and perhaps even flat, should we also test that the size of each order is the right proportion of the total base? This ensures the math is correct.

crispheaney · 2026-02-03T14:28:28Z

programs/drift/src/controller/scale_orders.rs

@@ -0,0 +1,266 @@
+use crate::controller::position::PositionDirection;


the controller dir historically just for mutating account state

Since this a lot of validation and generating order params, i think itd be more consistent if you make these methods on the ScaledOrderParams struct

Since order_params state file is already pretty bloated, can make a new state file scaled_order_params for the struct + impl fns

programs/drift/src/instructions/user.rs

crispheaney · 2026-02-04T16:41:14Z

programs/drift/src/state/scale_order_params.rs

+        let current_open_orders = user
+            .orders
+            .iter()
+            .filter(|o| o.status == OrderStatus::Open)


check order.is_available()

lowkeynicc added 6 commits January 27, 2026 22:48

add scale orders ix

2d43d82

fix tests

d402be7

allow up to 32 orders

a706c4f

flip start/end price logic

65e2692

cleanup

3e735fe

add spot

e6da376

LukasDeco reviewed Jan 29, 2026

View reviewed changes

crispheaney reviewed Feb 3, 2026

View reviewed changes

refactor

7b4e9bd