Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds "deadline" support across the SDK, including new driver resolution, conversion utilities, and behaviors around donation and Drip List creation/update. The PR also introduces comprehensive unit/integration tests for deadline-related flows and removes the testing-app sandbox.
- Add tests for deadline timestamp conversion and repoDeadline driver resolution
- Extend Drip List creation/update logic and tests with allowExternalDonations and deadline-config parsing
- Add unit/integration tests for calculating deadline driver account IDs and one-time donations with deadlines, and remove testing-app
Reviewed Changes
Copilot reviewed 142 out of 198 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/shared/toDeadlineSeconds.test.ts | New tests for validating Date-to-seconds conversion and error cases. |
| tests/unit/shared/resolveDriverName.test.ts | Adds support for driver ID 5 as repoDeadline; updates unknown ID tests. |
| tests/unit/shared/receiverUtils.test.ts | Tests for resolving deadline accounts and parsing receivers with deadline config. |
| tests/unit/shared/calcDeadlineDriverAccountId.test.ts | Extensive tests around building calls, chain-specific contracts, and edge cases. |
| tests/unit/dripLists/updateDripList.test.ts | Updates expected return shape to include allowExternalDonations. |
| tests/unit/dripLists/prepareDripListUpdate.test.ts | Tests allowExternalDonations toggling logic based on deadline receivers. |
| tests/unit/dripLists/prepareDripListCreation.test.ts | Adds owner account resolution and allowExternalDonations metadata; deadlines parsing. |
| tests/unit/dripLists/createDripList.test.ts | Aligns expectations to include allowExternalDonations; minor text change. |
| tests/unit/dripLists/buildDripListMetadata.test.ts | Ensures allowExternalDonations is part of built metadata. |
| tests/unit/donations/prepareOneTimeDonation.test.ts | Adds deadline-config flows for project receivers, with validation error tests. |
| tests/integration/deadlines.integration.test.ts | Integration tests for creating Drip Lists with deadlines and verifying splits hash. |
| testing-app/* | Removes testing app configs and routes (no behavior impact on SDK). |
Files not reviewed (1)
- testing-app/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.