Exit build scripts on errors to no create incomplete docker images #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are given shell scripts in their parameter lists and therefore it's expected that they return errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
docker buildsuccessfully creates a docker image even ifmakeinbuild.shfails. The resulting Docker image is not useful, because it doesn't contain the compiled programs, but there is no obvious indication that there were problems. When starting the container it results in errors like this.It makes more sense to abort the build in such cases. The simplest way is to tell bash to exit the build script on errors with
set -e. This way errors on./configure,makeand all other steps are covered.An exception are the calls to
strip. These calls are given shell scripts in their command line arguments, resulting in an error exist status that can be ignored.