Skip to content

Conversation

@bkk-bcd
Copy link
Contributor

@bkk-bcd bkk-bcd commented Jun 16, 2022

Alternative fix for #31

Allows service accounts to be created/managed by helm for drone in the usual fashion. Code copied directly from helm create with the exception of the required drone.serviceAccountName helper which was already defined.

Schema update copied from drone-runner-docker.

Left automountServiceAccountToken as is (https://github.com/drone/charts/pull/76/files#diff-085c19ead4ddab83dba353448d341f2781cbb60599e04b9a36da2a50b2f681e7R29)

@teryaev
Copy link

teryaev commented Jun 21, 2022

Hi Drone team. Any progress on this one? That would be great to have that implemented

@jimsheldon jimsheldon added the enhancement New feature or request label Jun 24, 2022
@jimsheldon
Copy link
Contributor

Apologies for the delay. Thank you for the contribution!

@jimsheldon jimsheldon merged commit 65ca29c into drone:master Jun 24, 2022
@bkk-bcd
Copy link
Contributor Author

bkk-bcd commented Jun 24, 2022

Thanks! Let me know if any issues come up (we did test it on our cluster so hopefully not) and I can fix it.

@bkk-bcd
Copy link
Contributor Author

bkk-bcd commented Jun 26, 2022

@jimsheldon do you think you can publish this on Monday?

❯ helm search repo drone
NAME                          	CHART VERSION	APP VERSION	DESCRIPTION
drone/drone                   	0.2.5        	2.12.0     	Drone is a self-service Continuous Delivery pla...
drone/drone-kubernetes-secrets	0.1.2        	1.0.0      	A Kubernetes Secrets extension for Drone
drone/drone-runner-kube       	0.1.8        	1.0.0      	The Drone Kubernetes runner launches builds in ...

@ShelRoman this is why our deployment is failing --^

@jimsheldon
Copy link
Contributor

@bkk-bcd I think you just need to run helm repo update, then you should see the newer drone chart 0.3.0

$ helm repo update drone
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "drone" chart repository
Update Complete. ⎈Happy Helming!⎈
$ helm search repo drone
NAME                            CHART VERSION   APP VERSION     DESCRIPTION
drone/drone                     0.3.0           2.12.0          Drone is a self-service Continuous Delivery pla...

@bkk-bcd
Copy link
Contributor Author

bkk-bcd commented Jun 28, 2022

helm repo update

Ah geeze you are right. Think I've been spoiled by ArgoCD a bit to much! Sorry to be a bother, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants