This repository was archived by the owner on Jan 5, 2018. It is now read-only.
Rendered Video psuedo-field#23
Open
NickDickinsonWilde wants to merge 2 commits intodrupal-media:8.x-1.xfrom
Open
Rendered Video psuedo-field#23NickDickinsonWilde wants to merge 2 commits intodrupal-media:8.x-1.xfrom
NickDickinsonWilde wants to merge 2 commits intodrupal-media:8.x-1.xfrom
Conversation
media_entity_embeddable_video.module
Outdated
Author
There was a problem hiding this comment.
yes, removed in added commit.
Member
|
Great, this looks good. Please create an issue in d.o. issue queue and cross-link it with this PR. It would also be great to sqush commits and reword commit message in accordance with drupal.org standards: https://www.drupal.org/node/52287 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a pseudo-field to render the video. Really it needs a selection of options but works right now. (at least for YouTube vids - haven't test it with the other videos)
see also https://www.drupal.org/node/2570261