Skip to content

Removed unnecessary command_parent attribute from CommandParameters #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dskrypa merged 1 commit into from
Dec 20, 2025
Merged

Removed unnecessary command_parent attribute from CommandParameters #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions lib/cli_command_parser/command_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class CommandParameters:
# fmt: off
command: CommandCls #: The Command associated with this CommandParameters object
formatter: CommandHelpFormatter #: The formatter used for this Command's help text
command_parent: CommandCls | None #: The parent Command, if any
parent: CommandParameters | None #: The parent Command's CommandParameters
action: Action | None = None #: An Action Parameter, if specified
_pass_thru: PassThru | None = None #: A PassThru Parameter, if specified
Expand All @@ -49,15 +48,8 @@ class CommandParameters:
option_map: OptionMap #: Mapping of {--opt / -opt: Parameter}
# fmt: on

def __init__(
self,
command: CommandCls,
command_parent: CommandCls | None,
parent_params: CommandParameters | None,
config: CommandConfig,
):
def __init__(self, command: CommandCls, parent_params: CommandParameters | None, config: CommandConfig):
self.command = command
self.command_parent = command_parent
self.parent = parent_params
self.config = config
self._process_parameters()
Expand Down Expand Up @@ -167,7 +159,7 @@ def _process_parameters(self):
while param_group := param_group.group:
groups.add(param_group)

if self.config.add_help and self.command_parent is not None and (not self.parent or not self.parent._has_help):
if self.config.add_help and self.parent is not None and not self.parent._has_help:
options.append(help_action)

self._process_positionals(positionals)
Expand Down
2 changes: 1 addition & 1 deletion lib/cli_command_parser/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def params(mcs, cls: CommandAny) -> CommandParameters:
cls = cls.__class__
parent = mcs.parent(cls, True)
parent_params = mcs.params(parent) if parent is not None else None
cls.__params = params = CommandParameters(cls, parent, parent_params, mcs.config(cls, DEFAULT_CONFIG))
cls.__params = params = CommandParameters(cls, parent_params, mcs.config(cls, DEFAULT_CONFIG))
return params

@classmethod
Expand Down
4 changes: 2 additions & 2 deletions tests/test_commands/test_command_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from unittest import TestCase, main

from cli_command_parser import Command, CommandConfig
from cli_command_parser.core import CommandMeta, _choice_items, get_config, get_params, get_parent
from cli_command_parser.core import CommandMeta, _choice_items, get_config, get_parent
from cli_command_parser.exceptions import CommandDefinitionError

_get_config = CommandMeta.config
Expand Down Expand Up @@ -49,7 +49,7 @@ class Foo(Command):
class Bar(Foo):
pass

self.assertEqual(get_params(Bar).command_parent, Foo)
self.assertEqual(get_parent(Bar), Foo)

def test_choice_items_results(self):
cases = [
Expand Down