Dealing with Multi threading issue#202
Open
je-vv wants to merge 1 commit intodsoprea:masterfrom
je-vv:master
Open
Dealing with Multi threading issue#202je-vv wants to merge 1 commit intodsoprea:masterfrom je-vv:master
je-vv wants to merge 1 commit intodsoprea:masterfrom
je-vv:master
Conversation
dsoprea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to: #132
So it happens that with fuse multi threading enabled, reading files breaks, to the point that a simple diff between directories fail a bunch of files if not all. It also gives quite a few weird errors.
This PR attempts to decouple threading from debugging, which in the original code are mixed and hard coded, leaving the option to the user to turn on/off multi threading, and having it disabled by default (the safe way).