Homepage schema filter by definition file type and documentation role #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbainter
force-pushed
the
alex-111-index-filter
branch
from
e1cd783 to
8043539
Compare
lisad
requested changes
Dec 17, 2025
Member
lisad
left a comment
lisad
left a comment
There was a problem hiding this comment.
I believe there's a duplicated method that behaves differently where it's copied over, otherwise this is good
| def __str__(self): | ||
| return self.name | ||
|
|
||
| @property |
Member
There was a problem hiding this comment.
It looks like def(language) is in here twice?
Collaborator
Author
There was a problem hiding this comment.
One is for SchemaRef and the other is for DocumenationItem and they do have meaningfully different implementations (different options for the possible languages)
lisad
approved these changes
Dec 18, 2025
Member
lisad
left a comment
lisad
left a comment
There was a problem hiding this comment.
Thanks for the clarification. I had an inkling I might be missing a class declaration although I tried to expando the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111 (though admittedly a little different from what was loosely specified)
Adds filtering by JSON or XML specification formats, and by RFC or W3C documentation roles on the homepage.
EDIT: After this recording was made I updated the logic to display "Showing [N] matching schemas" or "No matching schemas" when any of the filtering controls are used (not just search)
Screencast.From.2025-12-16.15-33-51.webm