aarex dimension: correctly subtract only cost, instead of set to 0#1
Open
petertseng wants to merge 1 commit intoducdat0507:mainfrom
petertseng:aarex-dim-cost
Open
aarex dimension: correctly subtract only cost, instead of set to 0#1petertseng wants to merge 1 commit intoducdat0507:mainfrom petertseng:aarex-dim-cost
petertseng wants to merge 1 commit intoducdat0507:mainfrom
petertseng:aarex-dim-cost
Conversation
With a `sub()`, the number would get set to NaN, and so `sub().max(0)` sets to 0. This means buying a single dimension always sets dimension points to zero, which unnecessarily penalises buying a single dimension. Instead, the cost should be subtracted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a
sub(), the number would get set to NaN, and sosub().max(0)sets to 0. This means buying a single dimension always sets dimension
points to zero, which unnecessarily penalises buying a single dimension.
Instead, the cost should be subtracted.