Skip to content

Reenable Juliads and Juliadf#145

Merged
Tmonster merged 2 commits intoduckdblabs:mainfrom
rchomjak:Reenable-Juliads-and-Juliadf
Jan 2, 2026
Merged

Reenable Juliads and Juliadf#145
Tmonster merged 2 commits intoduckdblabs:mainfrom
rchomjak:Reenable-Juliads-and-Juliadf

Conversation

@rchomjak
Copy link

@rchomjak rchomjak commented Dec 9, 2025

Based on the discussion on Julia GH pages e.g JuliaLang/julia#55765

I did investigation:
#135 (comment)

However, Has not been tested yet.

Related to this:
#135

@rchomjak
Copy link
Author

rchomjak commented Dec 9, 2025

@Tmonster Can you comment it, but in fact I haven't tested it yet? Not sure, if the Sys.unsetenv is better approach.

@Tmonster
Copy link
Collaborator

Tmonster commented Dec 9, 2025

@rchomjak can you add juliads and juliadf https://github.com/duckdblabs/db-benchmark/blob/85f7ee3cb8a6d7ae5b63ac65c22e9fb514c52e1a/.github/workflows/regression.yml#L20C39-L20C122 here as well? Then it should be able to test the regression tests as well

@rchomjak
Copy link
Author

rchomjak commented Dec 9, 2025

@Tmonster Added

@rchomjak
Copy link
Author

@Tmonster
Julia based engines passed, not sure if you want to test the second approach:

juliadf and juliads, has exec.sh, theoretically, in the shell script changing LD_* envars can be done.
(somewhere here https://github.com/rchomjak/db-benchmark/blob/fe09b515d5cf569abc6e5743c0423c40bb0e7176/juliadf/exec.sh#L12-L13)

@rchomjak
Copy link
Author

@rchomjak rchomjak marked this pull request as ready for review December 10, 2025 14:42
@rchomjak
Copy link
Author

rchomjak commented Jan 2, 2026

@Tmonster anything new?

@Tmonster
Copy link
Collaborator

Tmonster commented Jan 2, 2026

Looks good to me, thanks!

@Tmonster Tmonster merged commit 0b0974b into duckdblabs:main Jan 2, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants