Curve 2crv Strat: first release to Arbitrum

[pata-eth]

FWIW, my 'arbitrum-2crv' branch was created from the 'arbitrum-tricrypto' branch, but I noticed that your 'arbitrum-2crv' branch was created from main. I didn't notice any material differences in the 'diff'. I look forward to your feedback. Thank you!

Issue: https://github.com/yearn/yearn-strategies/issues/276

[pata-eth]

converted this one to draft until we sort out the reward claim process for all new curve gauges.

[pata-eth]

@poolpitako and @dudesahn, given the material changes of the commit I just pushed, we may want to have poolpi review its diff so that he can confirm he still approves the PR as it currently stands. Thank you both!

[pata-eth]

@poolpitako and @dudesahn, I've updated this PR in line with the feedback I received for ftm-tricrypto. Please let me know when you are ready to involve security. Thank you

[pata-eth]

Thanks again, for the feedback @dudesahn ! I've fixed my linter and updated the code according to your feedback. We still have a few open conversations unresolved, but I think this is ready for @poolpitako's final review. I may submit one more change based on how we resolve our pending items. Thank you

[pata-eth]

@dudesahn, I added keepCRV back. I think I've now taken care of all the requests. Please validate at your earliest convenience. Thank you

[dudesahn]

https://github.com/pata-eth/StrategyCurveTemplate/blob/16c2cbd3ae25ad38b42e400202ed54df5abedc95/contracts/StrategyCurveTwoPool.sol#L222

you can delete this line since you don't call that function anywhere

[dudesahn]

non-blocking, but in the future I would encourage you to use natspec for your comments of functions/state vars—that way they show up nicely on etherscan. I did this for my most recent iteration of strategies and am pretty happy with it.

[dudesahn]

https://github.com/pata-eth/StrategyCurveTemplate/blob/16c2cbd3ae25ad38b42e400202ed54df5abedc95/contracts/StrategyCurveTwoPool.sol#L16

Also, I think you can delete lines 16 and 18, as these are already inherited from the baseStrategy. again, not a big deal tho.

[dudesahn]

LGTM as my comments are non-blocking

[pata-eth]

non-blocking, but in the future I would encourage you to use natspec for your comments of functions/state vars—that way they show up nicely on etherscan. I did this for my most recent iteration of strategies and am pretty happy with it.

Absolutely. In my new projects I'm already incorporating natspec. So much better!

[pata-eth]

https://github.com/pata-eth/StrategyCurveTemplate/blob/16c2cbd3ae25ad38b42e400202ed54df5abedc95/contracts/StrategyCurveTwoPool.sol#L16

Also, I think you can delete lines 16 and 18, as these are already inherited from the baseStrategy. again, not a big deal tho.

Do you know why we can remove these lines but not lines 6 and 7?

[dudesahn]

you should be able to remove those as well :)