Fix PHP 8.5 deprecation warning #47
Merged
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyparker
force-pushed
the
php-85-deprecation-fix-v2
branch
from
321f581 to
d741f29
Compare
|
@jeffreyparker Do we have an estimated timeline for when this change will be available for use? |
mihir-pradhan
approved these changes
Feb 3, 2026
Contributor
Author
|
@glo71317 I just merged the fix in, so it should be available using |
This was referenced Feb 3, 2026
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.5 deprecated the
curl_close()function because cURL handles are now objects (CurlHandle), and PHP's garbage collector automatically frees them — callingcurl_close()no longer does anything.Reference: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.curl
Removing the call from the destructor avoids deprecation notices for users of the library on PHP 8.5+.
Context
This is a resubmission of #43 to trigger CI checks and add additional PHP versions to CI.
Credit to @sandesh-as for the original fix.