Conversation
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Failure
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Failure
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Failure
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Error
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Failure
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Failure
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Failure
saxonww
had a problem deploying
to
authenticode-signing
GitHub Actions
Failure
saxonww
temporarily deployed
to
authenticode-signing
GitHub Actions
Inactive
AaronAtDuo
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a package and sign workflow. It uses jsign to enable signing with an HSM-controlled key.
Motivation and Context
Our current signing certificate was generated from a private key itself generated in an HSM. It is not easy to use
dotnet signordotnet nuget signwith the HSM-backed key.Similarly, our internal CI is moving from GitLab to GitHub Actions. It is not possible for a public repository to pull workflows or actions from a private one, so we have to implement this part of our release process locally.
How Has This Been Tested?
We validated that signing works by temporarily having a PR sign (and discard) a .nupkg.
Types of Changes