Improve performance of graph automorphism via faster refinement and r… #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianGitt
commented
Jan 16, 2026
SebastianGitt
commented
Jan 16, 2026
| for u_i in self._u_vector: | ||
| for h in u_i: | ||
| f = mult(g, h) | ||
| if (f == self._identity).all(): |
Contributor
Author
There was a problem hiding this comment.
For large graphs this short-circuit takes longer to check than it ends up saving, hence its removal.
randomir
approved these changes
Jan 28, 2026
Member
randomir
left a comment
randomir
left a comment
There was a problem hiding this comment.
Looks good, just a few minor suggestions.
I'll defer the algorithm validation to @jackraymond.
…emoval of ``change_base()`` - uses an optimized colour refinement algorithm - more efficiently handles graphs with disjoint components - fixes issue where automorphisms could be missed if coset representatives could belong to multiple left transversals - supports canonical labelling - faster graph comparison using refinement trace - no longer relies on ``change_base()`` to perform pruning by automorphism - uses more efficient data structures - now returns mapping to original graph labelling - improves test coverage of edge cases - caches coset representative inverses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emoval of
change_base()change_base()to perform pruning by automorphism