-
Notifications
You must be signed in to change notification settings - Fork 1
Fix responsive issue. #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CSS styling to fix width/overflow issues with code blocks in the react-github-permalink component. The changes implement a Stack Overflow solution to properly constrain pre elements within the .rgp-base container.
- Adds nested CSS rules targeting pre elements within
.rgp-baseusing CSS nesting syntax - Implements width constraints using
width: 0andmin-width: calc(100% - 2em)with!importantflags - Includes commented-out code showing alternative approaches that were considered
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/app/globals.css
Outdated
| display: block; | ||
| overflow-x: auto; | ||
| white-space: pre-wrap !important; | ||
| /* max-width: calc(100% - 150px); */ |
Copilot
AI
Nov 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented-out code should be removed before merging to production. If this alternative solution needs to be preserved for reference, consider documenting why it was rejected or move it to commit history.
| /* max-width: calc(100% - 150px); */ |
src/app/globals.css
Outdated
| /* .rgp-base { | ||
| max-width: 60%; | ||
| } */ | ||
|
|
Copilot
AI
Nov 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented-out code should be removed before merging to production. If this alternative solution needs to be preserved for reference, consider documenting why it was rejected or move it to commit history.
| /* .rgp-base { | |
| max-width: 60%; | |
| } */ |
src/app/globals.css
Outdated
| /* .link-wrapper { | ||
| max-width: 300px; | ||
| } */ |
Copilot
AI
Nov 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented-out code should be removed before merging to production. If this alternative solution needs to be preserved for reference, consider documenting why it was rejected or move it to commit history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
|
@dwjohnston I've opened a new pull request, #259, to work on those changes. Once the pull request is ready, I'll request review from you. |
b7b7944 to
24b7799
Compare
No description provided.