Open
Conversation
Owner
|
Looks good! Seems like a useful option. It would be good to include a couple of tests, maybe one to assert that when |
Author
|
Yeah that's a great idea, I've made a quick fix for my own purposes. And, finally, I have rewrite the whole service to integrate the component feature. It's still in progress work (you can check it here : https://github.com/HollyPony/angular-modal-service) . I'll look for unit test and a document.createElement approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple wrapper option to encapsulate the template in a div.
I find it useful to manage dynamic modal based on routes (like my own use case), and not have to manage a third part element with appendElement option.
I'm open to discussions (since it's my first contact with you 🤗)