Skip to content

Comments

feat: wrapper option#233

Open
HollyPony wants to merge 1 commit intodwmkerr:masterfrom
HollyPony:wrapper-option
Open

feat: wrapper option#233
HollyPony wants to merge 1 commit intodwmkerr:masterfrom
HollyPony:wrapper-option

Conversation

@HollyPony
Copy link

Add a simple wrapper option to encapsulate the template in a div.

I find it useful to manage dynamic modal based on routes (like my own use case), and not have to manage a third part element with appendElement option.

I'm open to discussions (since it's my first contact with you 🤗)

@dwmkerr
Copy link
Owner

dwmkerr commented Feb 6, 2018

Looks good! Seems like a useful option. It would be good to include a couple of tests, maybe one to assert that when wrapper is true, the element is wrapped, and another to test that if wrapperClass is provided, it is set on the element, WDYT?

@HollyPony
Copy link
Author

Yeah that's a great idea, I've made a quick fix for my own purposes. And, finally, I have rewrite the whole service to integrate the component feature. It's still in progress work (you can check it here : https://github.com/HollyPony/angular-modal-service) .

I'll look for unit test and a document.createElement approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants