Wait for scope bindings to be set before initializing component modals.#280
Open
DougKeller wants to merge 3 commits intodwmkerr:masterfrom
Open
Wait for scope bindings to be set before initializing component modals.#280DougKeller wants to merge 3 commits intodwmkerr:masterfrom
DougKeller wants to merge 3 commits intodwmkerr:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
+ Coverage 88.54% 88.72% +0.17%
==========================================
Files 1 1
Lines 131 133 +2
==========================================
+ Hits 116 118 +2
Misses 15 15
Continue to review full report at Codecov.
|
This ensures that component bindings are available in the $onInit callback of the component's lifecycle This addresses the main issue brought up by dwmkerr#270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that component bindings are available in the $onInit callback of the component's lifecycle
This addresses the main issue with $onInit brought up by #270