Added autofocus support for input items in modal template#67
Open
lexbailey wants to merge 1 commit intodwmkerr:masterfrom
Open
Added autofocus support for input items in modal template#67lexbailey wants to merge 1 commit intodwmkerr:masterfrom
lexbailey wants to merge 1 commit intodwmkerr:masterfrom
Conversation
Owner
|
@danieljabailey Hi Daniel, thanks for this. If there is an element with an autofocus field elsewhere in the document tree, for example before and after the modal, this could interfere with the logic yes? |
Author
|
@dwmkerr Yeah, probably but it doesn't make much sense to have two things set to autofocus. You can only focus one of them at a time anyway. |
|
interesting branch, however I would refocus on the last element which was focused before the modal to open up. Before we open the modal: // Keep the current focused element
self.previousFocus = document.activeElement;Right after we close it // Set the focus back to the kept element (if any)
self.previousFocus && self.previousFocus.focus(); |
|
My solution to this is: // We now have a modal object...
var modal = {
controller: modalController,
scope: modalScope,
element: modalElement,
close: closeDeferred.promise,
closed: closedDeferred.promise
};
angular.forEach(modalElement.find('input'), function(input) {
if (input.attributes.getNamedItem('autofocus')) {
input.focus();
}
});
// ...which is passed to the caller via the promise.
deferred.resolve(modal);This allows you to have multiple modal templates on a single page and autofocus will work in each of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm new to Angular and Bootstrap and was looking at this modal service. It mostly does what I wanted but it would only autofocus the input box the first time it appeared. I have added some code that looks for any inputs with the autofocus attribute, if it finds one then it focuses it.
At the moment this relies on a timeout. It doesn't work without the timeout but there may be a better way to get it to happen at the correct time, I don't know enough about angular or bootstrap to be able to come up with a better way.
The complex example should now autofocus the name box.