feat: optimize UI terminology for content marketers and add experiment decorator #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add typed properties for all injected services (PHP 8.0+ syntax) - Fix drupal-check script to use composer require drupal/rl instead of local mounting for consistent cross-environment testing - Add @phpstan-ignore comments for standard Drupal patterns: - Views QueryPluginBase SQL-specific methods - Views ResultRow dynamic properties - new static() in dependency injection - Drupal static calls in form context - Pass all linters with 0 errors, 0 warnings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update UI strings to be more accessible to content marketers: - Change "Turns" to "Impressions" for content visibility tracking - Change "Rewards" to "Conversions" for click tracking - Change "algorithm" to "system" for less technical language - Remove "machine learning" from description Add experiment decorator for human-readable labels: - Create AiSortingExperimentDecorator service - Register decorator in ai_sorting.services.yml with rl.experiment_decorator tag - Decorator provides entity labels for arm IDs from view base entity type - Shows entity title with ID in parentheses in RL reports Fixes #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the AI Sorting UI to be more accessible to content marketers and adds the experiment decorator for human-readable labels in RL reports.
UI Terminology Updates
New Experiment Decorator
AiSortingExperimentDecoratorserviceFixes #16
Test Plan