fix: restore menu hover color defaults for hover styles #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2026 16:34
Remove navigation color variable defaults from variables.scss and add contextual CSS fallbacks in dxpr-theme-navigation-colors.scss. This fixes a regression from PR #713 where menu hover styles ('Colored text' and 'Colored background') stopped working when Menu Hover Text/ Background was set to 'None (Theme Default)'. Changes: - Remove 16 navigation color CSS variable defaults from variables.scss - Add CSS fallbacks directly where variables are used - 'Colored text' hover style falls back to var(--dxt-color-base) - 'Colored background' hover style falls back to var(--dxt-color-base) - Mobile menu hover also falls back to primary color for visibility Fixes #753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
This PR fixes a regression from PR #713 where menu hover styles ('Colored text' and 'Colored background') stopped working when the hover color settings were set to 'None (Theme Default)'.
Root cause: PR #713 added default values for navigation color CSS variables in
variables.scssthat pointed toheadertext/headercolors. This meant the CSS fallback syntaxvar(--variable, fallback)never triggered because the variable was always defined.Fix:
scss/base/variables.scssscss/components/dxpr-theme-navigation-colors.scssvar(--dxt-color-base)(primary color)Variables removed from defaults:
dropdown-background,dropdown-hover-background,dropdown-hover-text-color,dropdown-text-colorheader-block-background,header-block-text-colormenu-background,menu-hover-background,menu-hover-text-color,menu-text-colormobile-menu-background,mobile-menu-hover-background,mobile-menu-hover-text-color,mobile-menu-text-colornavbar-background,navbar-text-colorChecklist