fix: add Plotly.js installation docs and missing library warning #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjroelofs
force-pushed
the
fix/readme-plotly-docs
branch
from
a9807d0 to
8587911
Compare
The status report references the README for installation details, but the documentation was missing. Add CLI commands for: - Asset Packagist repository configuration - oomphinc/composer-installers-extender setup - Plotly.js installation Closes #21
jjroelofs
force-pushed
the
fix/readme-plotly-docs
branch
from
8587911 to
4fd89f7
Compare
jjroelofs
changed the title
Replace \Drupal::service() call with injected LibrariesDirectoryFileFinder to follow Drupal coding standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The status report references the README for Plotly.js installation details, but the documentation was missing. Also, users got a confusing JavaScript error when viewing experiment charts without Plotly installed.
Changes
README documentation:
User experience:
Code quality:
Test Plan
Closes #21