fix: remove unused variable in RlAnalyzer.php #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjroelofs
force-pushed
the
fix/lint-unused-variable
branch
from
4bb25c3 to
89516db
Compare
- Remove unused $center variable in RlAnalyzer.php - Remove dead try-catch blocks in RlCommands.php (InvalidArgumentException never thrown) - Fix null coalesce by extracting rate variables with empty array check Fixes #28
jjroelofs
force-pushed
the
fix/lint-unused-variable
branch
from
89516db to
8c18b2a
Compare
jjroelofs
added a commit
that referenced
this pull request
Jan 28, 2026
This reverts commit dc5557c.
jjroelofs
added a commit
that referenced
this pull request
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused
$centervariable from the Wilson score interval calculation inRlAnalyzer.php.Changes
The
$centervariable was calculated as part of the Wilson score interval formula but was never used. Only$spreadis needed to compute the confidence interval width.Lint Output (before fix)
Test Plan
docker compose run --rm drupal-lint)Fixes #28