Upgrade to SilverStripe 6

[jsirish]

Upgrades the module to SilverStripe 6 compatibility.

Changes

• Updated PHP requirement to ^8.1
• Updated core dependency silverstripe/recipe-core from ^5 to ^6
• Updated dynamic/silverstripe-country-dropdown-field from ^2 to ^3 (SS6 compatible)
• Fixed namespace changes:
  • Extension: SilverStripe\ORM\DataExtension → SilverStripe\Core\Extension
• Removed parent::onBeforeWrite() call (Extension base class doesn't have this method)
• Changed onBeforeWrite() visibility to protected (SS6 standard)
• Removed branch-alias

Testing

• ✅ PHPUnit: 6/6 tests passing
• ✅ PHPCS: Clean
• ✅ Code follows SS6 Extension patterns

This prepares the module for the 4.0.0 release and resolves dependency issues blocking other Dynamic modules from upgrading to SS6.

[Copilot]

Pull Request Overview

This PR upgrades the module to SilverStripe 6 compatibility by updating core dependencies and adapting to SS6 Extension patterns.

• Updated core framework dependency from silverstripe/recipe-core ^5 to ^6
• Migrated from DataExtension to Extension base class following SS6 namespace changes
• Adjusted onBeforeWrite() hook to protected visibility and removed obsolete parent call

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/AddressDataExtension.php	Changed base class from DataExtension to Extension, updated onBeforeWrite to protected visibility, removed parent call
src/DistanceDataExtension.php	Changed base class from DataExtension to Extension
composer.json	Updated PHP requirement to ^8.1, silverstripe/recipe-core to ^6, country-dropdown-field to ^3, and branch-alias to 4.0.x-dev

Comments suppressed due to low confidence (2)

src/AddressDataExtension.php:23

• The @Property annotation incorrectly documents $owner as type AddressDataExtension. Since this is an Extension, the $owner property represents the DataObject being extended, not the extension itself. This should document the actual owner class type (e.g., DataObject or the specific class this extension is applied to) or be removed entirely if the owner type varies.

 * @property AddressDataExtension $owner

src/AddressDataExtension.php:346

• The onBeforeWrite() method lacks test coverage for the geocoding behavior it provides. This is a critical functionality that automatically updates latitude and longitude coordinates. Consider adding tests to verify that coordinates are correctly set when an address is provided, and that geocoding is skipped when LatLngOverride is true or disable_geocoding is set.

    protected function onBeforeWrite()
    {
        if ($this->hasAddress() && !$this->owner->config()->get('disable_geocoding')
            && Config::inst()->get(GoogleGeocoder::class, 'geocoder_api_key')) {
            if (!$this->isAddressChanged()) {
                return;
            }
            if ($this->owner->LatLngOverride) {
                return;
            }
            if ($address = $this->getFullAddress()) {
                $geocoder = new GoogleGeocoder($address);
                $response = $geocoder->getResult();
                $this->owner->Lat = $response->getCoordinates()->getLatitude();
                $this->owner->Lng = $response->getCoordinates()->getLongitude();
            }
        }
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The @Property annotation incorrectly documents $owner as type DistanceDataExtension. Since this is an Extension, the $owner property represents the DataObject being extended, not the extension itself. This should document the actual owner class type (e.g., DataObject or the specific class this extension is applied to) or be removed entirely if the owner type varies.

Suggested change

* @property DistanceDataExtension $owner

[Copilot]

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This should be use SilverStripe\ORM\DataExtension; instead of use SilverStripe\Core\Extension;.

This extension is designed to extend DataObjects (as shown in the README and TestLocation.php), and uses DataObject-specific hooks like augmentSQL(). The augmentSQL() method is only available in DataExtension, not in the base Extension class.

In SilverStripe 6, SilverStripe\ORM\DataExtension still exists and should be used for DataObject extensions. The base SilverStripe\Core\Extension is only for extending non-DataObject classes.

[Copilot]

This should be use SilverStripe\ORM\DataExtension; instead of use SilverStripe\Core\Extension;.

This extension is designed to extend DataObjects (as shown in the README and TestLocation.php), and uses DataObject-specific hooks like onBeforeWrite(). In SilverStripe 6, SilverStripe\ORM\DataExtension still exists and should be used for DataObject extensions.

[Copilot]

This should be class AddressDataExtension extends DataExtension instead of extends Extension.

The onBeforeWrite() method (line 329) and other DataObject extension features used in this class require extending SilverStripe\ORM\DataExtension, not the base Extension class.