Top.php update to use templates instead of hardcoded HTML#5348
Open
rica-carv wants to merge 8 commits intoe107inc:masterfrom
Open
Top.php update to use templates instead of hardcoded HTML#5348rica-carv wants to merge 8 commits intoe107inc:masterfrom
rica-carv wants to merge 8 commits intoe107inc:masterfrom
Conversation
Top.php updated to use forum templates, instead of hardcoded HTML
|
Code Climate has analyzed commit e08c9b3 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 48.9% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Top.php updated to use forum templates, instead of hardcoded HTML
Hardcoded HTML is still in file for use when template is not available...
Description
Updated top.php to use the newforumposts template
Work in progress...
The top.php file is merging several plugins, so i ask why not use a top.php file in every plugin instead of a common one?
How Has This Been Tested?
Tested in v.2.3.3
Types of Changes
Checklist