Open
Conversation
Contributor
Author
|
Personally i think this function could benefit from using templates, since it would give the flexibility to be rendered as one of the three possible HTML tags, as stated in the BS docs, with the same styling plugin wide or theme wide... Probably the overhead of adding a template parsing to this function is too much...
But it's just my thougths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added customization to enable tooltips on buttons and custom classes inside the dropdown lists
Description
Added the support to tags attributes
How Has This Been Tested?
Tested in latest github code
Types of Changes
Checklist