Noescape #20
Open
Noescape #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 25, 2016 07:35
Leftover bad links to detached/moved nodes. A few times I think a link back was needed, to remove it from the list. Some last/first child nodes not getting updated.
But independent of the document structure.
insertAfter was creating cycles, by not setting next.prev to prev! A better solution would be a setLink function, that if set to next, set the destination's next.prev.next to this, set the destination's next.prev to this, etc, to make sure no dangling links to old places were around. But... this should work...?
not firstChild, therefore prev_ !is null, right? hmph...
Tired of lonely text nodes with just "\n" in them.
could probably just ignore the asserts in detachFast, instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I was thinking as far as separating out entity escaping logic from the DOM parsing. It works...... a lot better.