Added carthage support. Refactored code. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Carthage support by moving the code into a framework, the Cocoa Pod path has been updated to reflect this change.
Member
|
Hi Josh, Thanks for the PR! I've asked our mobile team to review. 👍 |
Added support for iOS 8. Added more classes to umbrella header. Change the shared instance from `id` to `instancetype` this helps with Swift support.
Author
|
Cheers, Just a heads up my changes appear to have broken the sample project. My latest commit has some fixes for Swift support, Apple Pay support when using the module and I have set the deployment target to iOS 8, it has silenced a lot of deprecation notices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
#importsfor frameworks switched to@import.Notes:
I haven't tested the Cocoapod.