Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yedidyar
commented
Aug 17, 2024
| SuggestionMode, | ||
| SkinTonePickerLocation | ||
| } from './types/exposedTypes'; | ||
| export type { EmojiClickData } from './types/exposedTypes'; |
Contributor
Author
There was a problem hiding this comment.
@ealush this won't work without adding the type anotation and moving it to diffrent export not sure if it actually affecting the package types but I think it not
Contributor
Author
|
not sure what not working with the build |
ealush
force-pushed
the
master
branch
8 times, most recently
from
e1e9bc5 to
76f2b14
Compare
ealush
force-pushed
the
master
branch
5 times, most recently
from
6f0292c to
d2af775
Compare
ealush
force-pushed
the
master
branch
2 times, most recently
from
467cac6 to
d55c0c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this improvment makes the storybook build faster by about 50%