Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kahlai Same as my previous PR: I tested within a podman container and mostly ensure that Ansible did run without errors and that the wildfly service is running. You may need to adapt for this to work on EC2.
In a nutshell, you can remove the jcliff_extra and the 3 CLI templates. Socket and modcluster are now supported by JCliff and the configuration of the TCP_PING can be handled by providing a base configuration with a variable for the initial hosts (see second commits for this part).
If you prefer to have the jgroups configuration done by JCliff, you can still do it by providing a custom rule, using the appropriate of attribute, of the jcliff: module. But given the amount of configuration to define the TCPPING jgroup's stack, it seems better to me to simply provide a modified standalone.xml.