New Calculator factory (separate from NewCollectionBase) #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.1.0
Release 1.1.1
Develop to master
Release 1.2.1
Release 1.3.0
Fix for setup-python@v5 expecting string now
New 2.0.0 release
Release 2.1.0
Hotfix 2.1.0a
Hotfix_2.1.0b
Implements architecture decision from Discussion #160: - Add CalculatorBase: Abstract base class for physics calculators - Add CalculatorFactoryBase: Abstract factory for creating calculator instances - Add SimpleCalculatorFactory: Concrete factory using dictionary registry - Add deprecation warning to InterfaceFactoryTemplate - Make Map._store private (__store) to enforce encapsulation - Update parameter.py to use public API instead of private _store access - Add comprehensive unit tests for all new classes
rozyczko
added
[scope] enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
+ Coverage 81.15% 81.60% +0.44%
===========================================
Files 52 54 +2
Lines 4267 4381 +114
Branches 740 751 +11
===========================================
+ Hits 3463 3575 +112
- Misses 624 626 +2
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Issues brought up in #172 addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements architecture decision from Discussion #160: