-
Notifications
You must be signed in to change notification settings - Fork 6
Update versions #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
netojoaobatista
wants to merge
6
commits into
master
Choose a base branch
from
update_versions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update versions #196
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b9f2032
Update versions
netojoaobatista 4f01e07
Update dependency versions
netojoaobatista e0aa425
Make tests compatible with phpunit 9.x
netojoaobatista f3160ad
Add a controlled environment to run the tests
netojoaobatista 5493caa
Ignore phpunit cache
netojoaobatista 9cda33b
Update travis php version
netojoaobatista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ | |
| /.env | ||
| /clover.xml | ||
| .php_cs.cache | ||
| .phpunit.result.cache | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| FROM php:7.4-cli | ||
|
|
||
| RUN apt-get update && apt-get -y --no-install-recommends install libzip-dev git zip unzip | ||
| RUN docker-php-ext-install zip | ||
|
|
||
| COPY . /src/benjamin | ||
| WORKDIR /src/benjamin | ||
|
|
||
| RUN php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" | ||
| RUN php -r "if (hash_file('sha384', 'composer-setup.php') === '906a84df04cea2aa72f40b5f787e49f22d4c2f19492ac310e8cba5b96ac8b64115ac402c8cd292b8a03482574915d1a8') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;" | ||
| RUN php composer-setup.php | ||
| RUN php -r "unlink('composer-setup.php');" | ||
| RUN mv composer.phar /usr/local/bin/composer | ||
| RUN chmod +x /usr/local/bin/composer | ||
| RUN composer install | ||
|
|
||
| CMD ["composer", "test-all"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Long time I don't check this repo.
Just make sure in case a php version goes unsupported (as in: no more security updates) it's a good idea to also raise the version to something secure and also test it with the latest version.
If we test the higher and lower limits we can be sure all versions in between will work.
That way in case a merchant is using an older version of PHP that has known CVEs we notify them (or ask their rep in merchant services to do so) so that they upgrade, no matter what the team lead says about supporting old versions! In case a team lead insists make them sign a document stating they will pay for the damages in case the merchant gets hacked, thank you! XD