use python-config in makefile and consolidate up .bin locations#1
Open
kylemcdonald wants to merge 2 commits intoebattenberg:masterfrom
Open
use python-config in makefile and consolidate up .bin locations#1kylemcdonald wants to merge 2 commits intoebattenberg:masterfrom
kylemcdonald wants to merge 2 commits intoebattenberg:masterfrom
Conversation
…y 1.9.2 installed with homebrew. added .gitignore and consolidated usage of data files.
Owner
|
Hi, thanks for your contribution! I haven't looked at this code in forever, so I'm not entirely sure how to figure out what modifications are necessary to get this to work. If your changes are what is necessary to get things working on your end, I have no problem merging them. I have no idea who is actually using this, so as far as I'm concerned, we can just merge. Would you be willing to write a README.md that describes the steps you took to successfully install? Also, it might be a good idea to write a few simple tests that we can use for regression testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All .bin files should now live in
data/pycuda/wasn'tmakeing for me until I usedpython-configto set all the variables telling gcc and nvcc about where Python was.There also seemed to be some discrepancy in how
cudavspycudaexpected to usematrix, so I added wrappers with different arguments so they could both use it.