darwin: Fix darwin int string mixing #357
Merged
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmc
force-pushed
the
fix-darwin-int-string-mixing
branch
from
b5d5bfe to
72a33da
Compare
hajimehoshi
reviewed
Oct 28, 2025
Member
hajimehoshi
left a comment
hajimehoshi
left a comment
There was a problem hiding this comment.
There seem a lot of TODOs. Is this intended?
Contributor
Author
|
I'll open a separate PR with the test generation code. I'm finding a host of darwin abi incompatibilities and opted to start generating the tests. |
Add test case that verifies multiple string arguments passed on the stack each receive their correct distinct values, rather than all receiving the same duplicated value. This test catches the bug fixed in the previous commit where v.String() was incorrectly used instead of val.String().
Use the correct loop variable 'val' instead of 'v' when converting string arguments to C strings. This ensures each string argument is properly converted rather than repeatedly using the same outer scope variable.
tmc
force-pushed
the
fix-darwin-int-string-mixing
branch
from
72a33da to
27c814f
Compare
hajimehoshi
approved these changes
Oct 28, 2025
Member
hajimehoshi
left a comment
hajimehoshi
left a comment
There was a problem hiding this comment.
LGTM
@TotallyGamerJet Please take a look
Contributor
Author
|
note: This change is included in #353 |
Member
hajimehoshi
reviewed
Oct 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where multiple string arguments passed on the stack were receiving duplicate values instead of their correct individual values. The issue was caused by using the outer loop variable instead of the inner loop variable when converting strings to C strings.
- Fixed incorrect variable reference in string conversion loop (line 290 of func.go)
- Added C test function
test_8i32_3stringsto verify multiple strings on stack work correctly - Added corresponding Go test case to validate the fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| func.go | Fixed bug where v.String() was used instead of val.String(), causing all stack strings to get the same value |
| testdata/abitest/abi_test.c | Added C function to test multiple strings passed on stack with 8 int32 parameters |
| func_test.go | Added test case that calls the new C function with 3 different strings to verify they maintain distinct values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Match the project's C formatting conventions: - Single-line function signatures - 4-space indentation - Consistent pointer spacing Addresses review feedback about line formatting.
hajimehoshi
reviewed
Oct 28, 2025
hajimehoshi
pushed a commit
that referenced
this pull request
Oct 29, 2025
Add test case that verifies multiple string arguments passed on the stack each receive their correct distinct values, rather than all receiving the same duplicated value. This test catches the bug fixed in the previous commit where v.String() was incorrectly used instead of val.String(). Closes #356
tmc
added a commit
to tmc/purego
that referenced
this pull request
Oct 29, 2025
Add test case that verifies multiple string arguments passed on the stack each receive their correct distinct values, rather than all receiving the same duplicated value. This test catches the bug fixed in the previous commit where v.String() was incorrectly used instead of val.String(). Closes ebitengine#356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
#356
What type of issue is this addressing?
bug
What this PR does | solves
Fixes improper use of outer loop variable when handling strings.
Additionally, adds a tool to generate various stack tests.