Open
Conversation
Closes https://github.com/ec-/baseq3a/issues/8. The bug has been introduced in 2c65e57. This commit basically brings back the code that was removed as part of that one. The intent of that commit was to spawn the powerups immediately for warmup, but then spawn them as usual when the warmup ends, in `G_WarmupEnd`. However, it's not always that we get to execute `G_WarmupEnd`. Namely, it doesn't get executed when `g_warmup 0` or in single player matches. The downside is, of course, that we no longer spawn the powerups for warmup immediately. So let's simply revert that change until a better solution is found.
WofWca
force-pushed
the
baseq3a-fix-powerup-immediate-spawn
branch
from
8426dd7 to
7de0e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8.
The bug has been introduced in
2c65e57.
This commit basically brings back the code that was removed
as part of that one.
The intent of that commit was to spawn the powerups immediately
for warmup, but then spawn them as usual when the warmup ends,
in
G_WarmupEnd.However, it's not always that we get to execute
G_WarmupEnd.Namely, it doesn't get executed when
g_warmup 0or in single player matches.
The downside is, of course, that we no longer spawn the powerups
for warmup immediately.
So let's simply revert that change until a better solution is found.
I have tested this
g_warmup 10g_warmup 0