fix: look at explosion on suicide, fix FF for mine#66
Open
WofWca wants to merge 1 commit intoec-:masterfrom
Open
fix: look at explosion on suicide, fix FF for mine#66WofWca wants to merge 1 commit intoec-:masterfrom
WofWca wants to merge 1 commit intoec-:masterfrom
Conversation
1. When killing self with a missile, look at the explosion instead of looking at the center of the world. 2. Make proximity mines not damage teammates, even with `g_friendlyFire 1`. This makes sense since proximity mines already don't damage self. I have checked through all the usages of `inflictor` inside of `G_Damage`: - `player_die() -> Team_FragBonuses`: unused. - `player_die -> LookAtKiller`: used, and it's the point of this commit. - `targ->use`: none of the `use` functions utilize `inflictor`. - `mod == MOD_PROXIMITY_MINE`: also fixes a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g_friendlyFire 1. This makes sense since proximity mines already don't damage self.I have checked through all the usages of
inflictorinside ofG_Damage:player_die() -> Team_FragBonuses: unused.player_die -> LookAtKiller: used, and it's the point of this commit.targ->use: none of theusefunctions utilizeinflictor.mod == MOD_PROXIMITY_MINE: also fixes a bug.