Skip to content

Only use HTTP/2 on certain java versions #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laeubi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only use HTTP/2 on certain java versions #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion ...c/org/eclipse/ecf/internal/provider/filetransfer/httpclientjava/ECFHttpClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.net.Authenticator;
import java.net.http.HttpClient;
import java.net.http.HttpClient.Redirect;
import java.net.http.HttpClient.Version;
import java.net.http.HttpRequest;
import java.security.NoSuchAlgorithmException;
import java.security.NoSuchProviderException;
Expand All @@ -37,6 +38,8 @@
@SuppressWarnings({ "restriction" })
@Component
public class ECFHttpClientFactory implements IHttpClientFactory {
private static final Runtime.Version JDK_BUG_8335181_JAVA21 = Runtime.Version.parse("21.0.8");
private static final Runtime.Version JDK_BUG_8335181_JAVA17 = Runtime.Version.parse("17.0.17");
@SuppressWarnings("unused")
private static final List<String> DEFAULT_PREFERRED_AUTH_SCHEMES_NO_NTLM = Arrays.asList("Basic","Digest");
@SuppressWarnings("unused")
Expand All @@ -51,7 +54,7 @@ public class ECFHttpClientFactory implements IHttpClientFactory {

@Override
public HttpClient.Builder newClient() {
HttpClient.Builder builder = HttpClient.newBuilder().followRedirects(Redirect.NORMAL);
HttpClient.Builder builder = HttpClient.newBuilder().version(getDefaultHttpVersion()).followRedirects(Redirect.NORMAL);
String sslContextProvider = HttpClientOptions.HTTPCLIENT_SSLCONTEXT_PROVIDER;
String sslContextProtocol = HttpClientOptions.HTTPCLIENT_SSLCONTEXT_PROTOCOL;
SSLContextFactory sslContextFactory = Activator.getDefault().getSSLContextFactory();
Expand Down Expand Up @@ -82,6 +85,24 @@ public HttpClient.Builder run(IHttpClientModifier modifier, HttpClient.Builder v
return builder;
}

private Version getDefaultHttpVersion() {
// See https://bugs.openjdk.org/browse/JDK-8335181
// Version with this bug are prone to spurious GOAWAY
// So we check here if it is safe to use HTTP/2
var version = Runtime.version();
int feature = version.feature();
if (feature >= 25) {
return Version.HTTP_2;
}
if (feature == 17 && version.compareTo(JDK_BUG_8335181_JAVA17) >= 0) {
return Version.HTTP_2;
}
if (feature == 21 && version.compareTo(JDK_BUG_8335181_JAVA21) >= 0) {
return Version.HTTP_2;
}
return Version.HTTP_1_1;
}

@Override
public IHttpClientContext newClientContext() {
IHttpClientContext context = new IHttpClientContext() {
Expand Down