Skip to content

Conversation

@merks
Copy link
Contributor

@merks merks commented Jan 11, 2026

  • Move 3rd party feature includes to the dependencies feature.
  • Eliminate errors accessing ambiguous activator class.
  • Provide an up-to-date, 2026-03 target file.

@eclipse-ecf-bot
Copy link

Can one of the admins verify this patch?

@merks
Copy link
Contributor Author

merks commented Jan 11, 2026

The error is a little odd complaining about something missing that is actually in the baseline repository...

image

Locally the build does the comparison with this result:

image

@laeubi
Copy link
Contributor

laeubi commented Jan 11, 2026

The error is a little odd complaining about something missing that is actually in the baseline repository...

This usually means you need a version increment or rebase of your branch.

@merks
Copy link
Contributor Author

merks commented Jan 11, 2026

It's odd because it doesn't fail locally (using the same profile) where it finds bundle. According to that, yes, there really should be a version increment based on the warning-level info we see locally. So the failure, if any, because it's configured to warning, should be about that, not about the bundle being missing from the baseline. Go figure. Also, the PR is based on master, so it can't be rebased. I know there have been problems with the download server today, so maybe that's a/the problem.

@merks merks force-pushed the pr-3rd-party-includes branch from 2958cf4 to f353da9 Compare January 11, 2026 18:09
@merks
Copy link
Contributor Author

merks commented Jan 11, 2026

At least it fails consistently the same way. 😕

@laeubi
Copy link
Contributor

laeubi commented Jan 12, 2026

So the failure, if any, because it's configured to warning, should be about that, not about the bundle being missing from the baseline

The problem is the following:

  1. It can't find a baseline (then you get a warning) and therefore it do not do any baseline replace. This can happen because the bundle is not there (e.g. its brand new) or because e.g. the build baseline repo (what is the last I-Build not the previous release) does not contain a bundle with that version (e.g. because a missing version increment)
  2. Then the compare fails because the bundle has changes (e.g. due to compiler version change) compared to the previous release baseline but no version increment, that will usually succeed because of the jar being replaced

- Move 3rd party feature includes to the dependencies feature.
- Eliminate errors accessing ambiguous activator class.
- Provide an up-to-date, 2026-03 target file.
- Increment versions for bundles with baseline replace problems.
@merks merks force-pushed the pr-3rd-party-includes branch from f353da9 to e71389e Compare January 12, 2026 07:28
@merks
Copy link
Contributor Author

merks commented Jan 12, 2026

@scottslewis

This PR is to address the following SimRel issue:

eclipse-simrel/simrel.build#1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants