feat: push simple transfer with data plane signaling #5425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| private class DataplaneOnTerminate implements OnTerminate { |
Check notice
Code scanning / CodeQL
Inner class could be static Note test
ndr-brt
force-pushed
the
5323-first-push-transfer-flow
branch
3 times, most recently
from
5bb15a2 to
ba903ba
Compare
ndr-brt
force-pushed
the
5323-first-push-transfer-flow
branch
from
ba903ba to
d73ae4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Actual data transfer using new data plane plane signaling spec
Why it does that
Briefly state why the change was necessary.
Further notes
DataFlowControllerbecause it would have been harder to duplicated json to pojo transformers, while with this implementation the serdes is done directly on pojoWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Part of #5323
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.