Remove beeping from FilteredTree #3605
Open
+34
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeping is annoying and beeping in a FilteredTree in certain internal situations does not add value for the user.
Contributor
|
Somehow discussions about beeps seem to ring a bells, so to speak. There are many calls: 
And indeed there is this thread: eclipse-platform/eclipse.platform.swt#2613 Maybe there are visually impaired people that will be unhappy? I have no clue. I don't like beeps personally, but that's just a personal opinion... |
Contributor
Author
|
eclipse-platform/eclipse.platform.swt#2613 triggered this change, the agreement seems to be that we should remove the beep from our code and once this is done, we should deprecate this method. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beeping is annoying and beeping in a FilteredTree in certain internal situations does not add value for the user.