-
Notifications
You must be signed in to change notification settings - Fork 7
[PLANPRO-5832] Signal ausleger with foundation #2047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JanErikVoigt
wants to merge
6
commits into
eclipse-set:main
Choose a base branch
from
JanErikVoigt:signal-ausleger-with-foundation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b0290c5
original meaning of getMountType
89383a8
add new, more refined condition for getMountType(SignalInfo)
3942e35
add Flash to getFeatureName
f076b5d
add anchors to HV Vr1
8b29a88
remove debugging text
1d440a9
use exists instead of !filter.isEmpty
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,6 +106,8 @@ export function getFeatureLayerByType (type: FeatureType): FeatureLayerType { | |
| return FeatureLayerType.Unknown | ||
| case FeatureType.TrackDirectionArrow: | ||
| return FeatureLayerType.TrackDirection | ||
| case FeatureType.Flash: | ||
| return FeatureLayerType.Flash | ||
| default: throw new Error('Missing layer for type: ' + type) | ||
| } | ||
| } | ||
|
|
@@ -194,6 +196,8 @@ export function getFeatureName (type: FeatureType): string { | |
| return 'Unbekannt' | ||
| case FeatureType.TrackDirectionArrow: | ||
| return 'GleisausrichtungsPfeil' | ||
| case FeatureType.Flash: | ||
| return 'Flash' // TODO | ||
|
Comment on lines
+199
to
+200
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, the flash layer shouldn`t avaible at the select layer side panel |
||
| default: | ||
| console.error('Missing name for type: ' + type) | ||
| return 'Unbenanntes Objekt' | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add the
Flashfeature here. By start this Layer haven't any feature