Skip to content

Minor changes for alpha4 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PLeVasseur merged 3 commits into from
Dec 4, 2025
Merged

Minor changes for alpha4 #329

PLeVasseur merged 3 commits into from
Dec 4, 2025

Conversation

@MaximilianToe
Copy link
Contributor

@MaximilianToe MaximilianToe commented Dec 3, 2025

Added some minor improvements for the alpha4-release. These include the following:

  • Deleted some unused files. This closes Remove utils::Base64 #214 and Remove utils::ThreadPool #216.
  • Added missing doc strings.
  • (optional, commit could be removed if not desired) Renamed invokeMethodToProto to invokeMethodFromProto for the cases where the input of the method in a protobuf object and the return value is either a Handle or a uMessage. This would name would better reflect the behaviour.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Code coverage report is ready! 📈

PLeVasseur
PLeVasseur approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful to see the documentation fill in! 🥰 Thank you for getting this ready.

@PLeVasseur PLeVasseur merged commit 43a571f into eclipse-uprotocol:main Dec 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PLeVasseur PLeVasseur PLeVasseur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove utils::Base64

2 participants

@MaximilianToe @PLeVasseur