Open
Conversation
peshence
approved these changes
Oct 3, 2025
Collaborator
peshence
left a comment
peshence
left a comment
There was a problem hiding this comment.
Cool, would it make sense to just generalise this to all operations?
| return hash_node(self) | ||
|
|
||
| def remove_branch(self, b: Qube) -> Qube: | ||
| b_key = b.children[0].key |
Collaborator
There was a problem hiding this comment.
should we enforce that b only has 1 child?
|
|
||
| return hash_node(self) | ||
|
|
||
| def remove_branch(self, b: Qube) -> Qube: |
Collaborator
There was a problem hiding this comment.
a docstring would be helpful here I think, e.g.
Suggested change
| def remove_branch(self, b: Qube) -> Qube: | |
| def remove_branch(self, b: Qube) -> Qube: | |
| """ | |
| Navigates down self until it finds a key that matches the top key of b, then subtracts b from the subtree. | |
| b can only have 1 child | |
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/qubed/pull-requests/PR-28